execution: add default value logic for scalar final agg in mock mpp executor #50982
Conversation
Signed-off-by: AilinKid <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/L
|
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #50982 +/- ##
=================================================
- Coverage 70.5452% 55.8514% -14.6938%
=================================================
Files 1466 1576 +110
Lines 434768 616408 +181640
=================================================
+ Hits 306708 344273 +37565
- Misses 108772 249383 +140611
- Partials 19288 22752 +3464
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@AilinKid: GitHub didn't allow me to request PR reviews from the following users: zhen. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@AilinKid: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #50893
Problem Summary:
What changed and how does it work?
previously mpp handler don't pay any attention to agg-pb‘s agg mode, which is to say they don't care about whether agg is finalAgg or partial ones. While for scalar finalAgg (when there is no groupKeys, itself is a scalar agg, which should be judged before running), default value logic filling is necessary, referred from current tidb execution and real tiflash logic. While for scalar partialAgg, filling default value logic is NOT necessary.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.